zvirt

Commit Graph

Author	SHA1	Message	Date
Nicolas Massé	023618bf62	Let zfs-autobackup decide which domains are configured Before handing a domain over, snapshot-libvirt-domains guarded it behind 'zfs get -s local autobackup:libvirt-<domain>' and tested the result for non-emptiness. That answers neither of the questions that matter. -s local drops exactly the inherited lines, while zfs-autobackup looks the property up without -s and resolves inheritance (ZfsNode.selected_datasets rewrites "inherited from <parent>" to the parent's source, ZfsDataset.is_selected takes an inherited flag). Configuring the fleet once on the parent dataset - the normal way to drive zfs-autobackup, and the only way to cover datasets that already exist without walking them one by one - therefore made zvirt skip every domain, while the very same backup names handed to zfs-autobackup by hand snapshotted all of them. The guard also had no dataset operand, so it asked "does any dataset in the pools carry this property locally?"; and it tested presence where zfs-autobackup tests value, so a local =false passed it, and child/parent were misjudged in both directions. Drop the guard and let zfs-autobackup answer, since it is the one selecting. It reports "nothing selected" as exit 255 with a distinctive message, so keep its stderr aside for the length of one domain, long enough to tell that case (skip the domain, carry on with the fleet, exit 0) from a genuine failure (replay the stderr, abort with its exit code). Its own wording is swallowed in the skip case: it is printed as an error while nothing failed. Document the selection in the README - the four property values, the fact that inheritance counts, and the two properties involved (autobackup:libvirt-<domain> to snapshot, autobackup:libvirt to prune). This does not cover the case of a domain whose selection misses part of its storage: the property selects datasets, not domains, and only zvirt knows what a domain is made of. Tracked in #3. Closes #2 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014BSA2qQpCr7cY4qDEX7kuX	3 weeks ago
Nicolas Massé	585df61e6f	Bump version to 0.0.7	3 weeks ago
Nicolas Massé	c4a1d54d86	Make the snapshot name format queryable The snapshot format was hardcoded in snapshot-libvirt-domains, so any tool pruning zvirt's snapshots had to copy the same literal. On a mismatch, zfs-autobackup selects the right datasets, matches none of their snapshots, destroys nothing and still exits 0 - snapshots then accumulate forever while the retention job reports success. Move the format to a sourceable file, /usr/share/zvirt/snapshot-format, that snapshot-libvirt-domains sources instead of hardcoding, so producer and consumer cannot drift. Also expose it as --print-snapshot-format for consumers that would rather not source a file. Document the retention run, the deliberate absence of a {} placeholder (it is what allows a single prune run to cover every domain), and the systemd specifier escaping trap. While here, fix the lint target: bin/*.sh matched no file, since neither script carries a .sh extension. Closes #1 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XaqxX5X9VGwQSvNEBYyZq1	3 weeks ago
Nicolas Massé	320c00179e	be smart: only snapshot running domains when in live mode	5 months ago
Nicolas Massé	9cfb5b3643	Bump version to 0.0.6	5 months ago
Nicolas Massé	da8f3b359b	final edits	5 months ago
Nicolas Massé	b84d07efec	rework the script to use zfs-autobackup underneath	5 months ago
Nicolas Massé	c972dd2d62	Bump version to 0.0.5	10 months ago
Nicolas Massé	b06bdbe2db	srpm are distro agnostic	10 months ago
Nicolas Massé	7dae9155b7	Bump version to 0.0.4	10 months ago
Nicolas Massé	3fd2efc39f	release mechanism	10 months ago
Nicolas Massé	69d96abadf	fix RPM version	10 months ago
Nicolas Massé	386e1478af	add copr build	10 months ago
Nicolas Massé	c1d3f9177f	implement the prune action	10 months ago
Nicolas Massé	b15a39c040	minor fixes	10 months ago
Nicolas Massé	8b7d14a72c	toward second release	10 months ago
Nicolas Massé	073ae1a027	prepare release	10 months ago
Nicolas Massé	62adeb2008	prepare release	10 months ago
Nicolas Massé	2c08663a3a	e2e tests, unit tests + fixes	10 months ago
Nicolas Massé	138c27e4aa	e2e tests	10 months ago
Nicolas Massé	d8b16c5ba5	add unit tests	10 months ago
Nicolas Massé	7c48b52aaf	use bats-core for unit testing	10 months ago
Nicolas Massé	297041fb57	initial commit	11 months ago

23 Commits (023618bf627e4b1e5a96098b8a25db36a16140f6) All Branches Search

23 Commits (023618bf627e4b1e5a96098b8a25db36a16140f6)

All Branches